Skip to content

Conversation

@bhavayAnand9
Copy link
Contributor

Proposed changes

channel avatar was not appearing in the top bar unlike direct message

Issue(s)

#19083

How to test or reproduce

Screenshots

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

display channel avatar in top bar

Further comments

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2020

CLA assistant check
All committers have signed the CLA.

@bhavayAnand9
Copy link
Contributor Author

Hi! @gabriellsh Can you please review this PR? Thanks

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove the isDirect from helpers since we don't use anymore? thanks :)

@bhavayAnand9 bhavayAnand9 requested a review from ggazzo October 13, 2020 19:19
@bhavayAnand9
Copy link
Contributor Author

Hi! @ggazzo I've removed the unused code, Please rereview. Thanks : )

@ggazzo ggazzo changed the title [IMPROVE] display channel avatar in top bar [IMPROVE] Display channel avatar on the Header Oct 13, 2020
@ggazzo ggazzo merged commit b5cd60f into RocketChat:develop Oct 13, 2020
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants