Skip to content

[IMPROVE] New sidebar layout #19089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gabriellsh merged 204 commits into from
Oct 26, 2020
Merged

[IMPROVE] New sidebar layout #19089

gabriellsh merged 204 commits into from
Oct 26, 2020

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 1, 2020 •
edited
Loading

Proposed changes

close #19209

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

MartinSchoeler and others added 30 commits August 26, 2020 14:25
@MartinSchoeler
wip
8b92156
@MartinSchoeler
wip
6e34e48
@MartinSchoeler
Merge remote-tracking branch 'origin/develop' into ref/omni-departments
7de42e8
@MartinSchoeler
more work in progress
c43ed83
@MartinSchoeler
lint
8b826a1
@ggazzo
Fix IE11 support livechat widget
9fc2cc6
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
56f6da3
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
db2cf6a
@MartinSchoeler
More wip
6bed223
@MartinSchoeler
lint
e2cdc0b
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
f26fce7
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
54ec471
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
6ab9283
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
9229622
@MartinSchoeler
Add correct buttons and fix some errors
d42faed
@MartinSchoeler
Merge remote-tracking branch 'origin/develop' into ref/omni-departments
68aecd2
@MartinSchoeler
fix import
bae5a24
@MartinSchoeler
Fix error with empty department agents
a06f54a
@MartinSchoeler
fix title and tags
af468cd
@MartinSchoeler
more fixes
7dee3dd
@MartinSchoeler
fix agents save
bcbf738
@MartinSchoeler
Fix agentlist not saving
ba661dd
@ggazzo
First Review
c900831
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
84f624d
@ggazzo
update fuselage
068c648
@ggazzo
Merge branch 'ref/omni-departments' into feat/sidebar
2b06454
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
202c117 
…/sidebar

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] LDAP avatar upload (#18994)
  Regression: Handle MongoDB authentication issues (#18993)
@gabriellsh
Sidebar variations
f265d87
@gabriellsh
Fix Stories
5ac002c
@gabriellsh
Sidebar Header
1979d64
@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2020

This pull request introduces 4 alerts when merging 7a3f758 into 9daf8e4 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2020

This pull request introduces 1 alert when merging 312dc78 into 61e4498 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

ggazzo and others added 19 commits October 21, 2020 16:13
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
2859908 
…/sidebar
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
c3e24d5 
…/sidebar
@gabriellsh
wip
856d140
@ggazzo
Merge branch 'feat/sidebar' of github.com:RocketChat/Rocket.Chat into…
89b8b9f 
… feat/sidebar
@ggazzo
Testing IE11
ffd92c9
@gabriellsh
WIP
25b7a16
@ggazzo
Fix Typo
ca82296
@ggazzo
Use Layout colors
186454a
@ggazzo
Lint
1e0d1e8
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
524b8fb 
…/sidebar
@ggazzo
Merge branch 'develop' into feat/sidebar
2fd4066
@ggazzo
Merge branch 'feat/sidebar' of github.com:RocketChat/Rocket.Chat into…
d4cef74 
… feat/sidebar
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
2392059 
…/sidebar
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
c3b7f0d 
…/sidebar
@ggazzo
Fix
e5d392d
@gabriellsh
Remove CallProvider
ab6b47f
@MartinSchoeler
Merge branch 'develop' into feat/sidebar
4c9ec81
@gabriellsh
Remove CallContext
2bbae03
@tassoevan
Merge branch 'develop' into feat/sidebar
6c0f456
@gabriellsh gabriellsh changed the title Rewrite: Sidebar [IMPROVE] New sidebar layout Oct 26, 2020
@gabriellsh gabriellsh merged commit edda351 into develop Oct 26, 2020
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Merged
@rodrigok rodrigok deleted the feat/sidebar branch November 25, 2020 17:11
@scratttt scratttt mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tassoevan tassoevan tassoevan left review comments

@renatobecker renatobecker renatobecker left review comments

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong user status in sidebar

6 participants

@ggazzo @tassoevan @MartinSchoeler @renatobecker @gabriellsh