Skip to content

[FIX] Wrong avatar urls when using providers #18929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 5 commits into from
Oct 13, 2020
Merged

[FIX] Wrong avatar urls when using providers #18929

ggazzo merged 5 commits into from
Oct 13, 2020

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Sep 16, 2020 •
edited by sampaiodiego
Loading

Issue(s)

Closes #18797

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@MartinSchoeler MartinSchoeler added this to the 3.7.0 milestone Sep 16, 2020
@MartinSchoeler MartinSchoeler requested a review from a team September 16, 2020 16:31
gabriellsh
gabriellsh requested changes Sep 29, 2020
View reviewed changes
client/components/basic/avatar/UserAvatar.js Outdated
import React from 'react';

import BaseAvatar from './BaseAvatar';
import { settings } from '../../../../app/settings';
Copy link
Member

@gabriellsh gabriellsh Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're supposed to use the SettingsContext (e.g. useSetting)

@ggazzo ggazzo merged commit 0b488a3 into develop Oct 13, 2020
@ggazzo ggazzo deleted the fix-avatar-provider branch October 13, 2020 22:53
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Merged
@reinaldonetof reinaldonetof mentioned this pull request Jun 1, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabriellsh gabriellsh gabriellsh requested changes

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

feat: user settings

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

[BUG] When use external avatar link, not work on modal profile and full profile

4 participants

@MartinSchoeler @ggazzo @gabriellsh