Skip to content

Regression: Edit messages after opening thread #18375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 1 commit into from
Jul 24, 2020
Merged

Regression: Edit messages after opening thread #18375

ggazzo merged 1 commit into from
Jul 24, 2020

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jul 24, 2020 •
edited
Loading

Proposed changes

Issue(s)

How to test or reproduce

Open thread, close thread, try to edit the thread's main message. It'll try to edit the message in the closed messageBox.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan added feat: threads / discussions Threads and Discussions area: ui Touches the code on client side type: regression labels Jul 24, 2020
@tassoevan tassoevan added this to the 3.5.0 milestone Jul 24, 2020
@ggazzo ggazzo merged commit 4e176de into develop Jul 24, 2020
@ggazzo ggazzo deleted the reg/editThread branch July 24, 2020 19:53
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tassoevan tassoevan tassoevan approved these changes

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

area: ui Touches the code on client side feat: threads / discussions Threads and Discussions type: regression

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@gabriellsh @tassoevan @ggazzo