[NEW] Standard Importer Structure #18357
Conversation
…rwhelm the connection
CSV importer is 100% done
|
This pull request introduces 1 alert when merging 18c446e into def02e9 - view on LGTM.com new alerts:
|
|
This is very cool. I'd like to help drive connecting this up with another project aimed at simplifying access to third-party data providers such as Google Contacts, GSuite, ADP, BambooHR, BreezyHR, Salesforce, Workday, etc. You can read about it here https://github.com/easybread/easybread/tree/develop/packages/core#easybread and see the documentation https://github.com/easybread/easybread/wiki/GeneralConcepts This would make it really cool for rocket.chat users that have an HR or directory like BambooHR, ADP, Gsuite, but no AD or LDAP. Also, easybread plans to support LDAP and AD as an adapter soon so we could potentially also take over RC's LDAP user sync code with the easybread adapter. Maybe even slack and other adapters could be implemented in easybread and then it would all just be in one module in RC and as easybread implements more adapters they instantly become available with a npm update of easybread on RC. I have a freelance developer that has done the majority of the work on easybread. We would be happy to work with the Rocket.Chat team to build out the UI functionality and having easybread importers available as part of the setup wizard and also in the administration dashboard. Imagine setting up a new Rocket.Chat server, clicking on an import from existing directory button, and being able to select any third party provider without any need for Rocket.Chat's team to maintain the adapters.
|
|
This pull request introduces 5 alerts when merging 71c7aea into 4e176de - view on LGTM.com new alerts:
|
|
This pull request introduces 5 alerts when merging 7291996 into ccc323f - view on LGTM.com new alerts:
|
|
i'll create a discussion on open. I don't want to let this sit un-answered too long |
Removed changes from PR #20216 that were made on the old structure - they need to be re-implemented on the new slack importer. # Conflicts: # app/importer-slack/server/importer.js
|
This pull request introduces 5 alerts when merging 91be6ad into f50d745 - view on LGTM.com new alerts:
|
|
Any particular reason we haven’t moved forward and merged? |
It's missing a few things, but I'll finish it for this month's release. |
|
This pull request introduces 1 alert when merging 687423c into dd340e0 - view on LGTM.com new alerts:
|
| this.reloadCount(); | ||
| const started = Date.now(); | ||
| const startedByUserId = Meteor.userId(); | ||
| console.log(importSelection); |
There was a problem hiding this comment.
| console.log(importSelection); |
|
This pull request introduces 1 alert when merging 4bfdaf4 into 880546b - view on LGTM.com new alerts:
|
| @@ -0,0 +1,17 @@ | |||
| export interface IImportUser { | |||
| // #ToDo: Remove this _id, as it isn't part of the imported data | |||
| this.reloadCount(); | ||
| const started = Date.now(); | ||
| const startedByUserId = Meteor.userId(); | ||
| console.log(importSelection); |
| fn(); | ||
| } catch (e) { | ||
| console.log('errror', e); // TODO: Remove | ||
| console.log('error', e); // TODO: Remove |
There was a problem hiding this comment.
I think this either should be a logger call or a console.error
|
|
||
| if (roomData.t === 'd') { | ||
| if (members.length < roomData.users.length) { | ||
| console.warn('One or more imported users not found: ${ roomData.users }'); |
There was a problem hiding this comment.
thx to LTGM.. this log will not show what is expected =)
btw, any reason to not use Logger?
There was a problem hiding this comment.
Not anymore, just didn't update this part of the code.
Proposed changes
This PR aims to simplify the data importers process by storing the data of any importer in a standard format that can be converted by the same process.
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments