Skip to content

Regression: Preferences crashing when User has no preferences set. #18341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 3 commits into from
Jul 21, 2020
Merged

Regression: Preferences crashing when User has no preferences set. #18341

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07ae53f
Fix preferences
gabriellsh Jul 21, 2020
f48d490
Merge branch 'develop' into fix/preferences
tassoevan Jul 21, 2020
7f86529
Apply suggestions from code review
ggazzo Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/account/preferences/PreferencesGlobalSection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { useForm } from '../../hooks/useForm';
const PreferencesGlobalSection = ({ onChange, ...props }) => {
const t = useTranslation();

const userDontAskAgainList = useUserPreference('dontAskAgainList');
const userDontAskAgainList = useUserPreference('dontAskAgainList') || [];
Comment thread
ggazzo marked this conversation as resolved.
Outdated

const options = useMemo(() => userDontAskAgainList.map(({ action, label }) => [action, label]), [userDontAskAgainList]);
Comment thread
ggazzo marked this conversation as resolved.
Outdated

Expand Down
2 changes: 1 addition & 1 deletion client/account/preferences/PreferencesLocalizationSection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { useForm } from '../../hooks/useForm';

const PreferencesLocalizationSection = ({ onChange, ...props }) => {
const t = useTranslation();
const userLanguage = useUserPreference('language');
const userLanguage = useUserPreference('language') || '';
const languages = useLanguages();

const languageOptions = useMemo(() => languages.map(({ key, name }) => [key, name]).sort(([a], [b]) => a - b), [languages]);
Expand Down