Skip to content

[FIX] Local Account login error when both LDAP and Email 2FA are enabled #18318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 2 commits into from
Jul 21, 2020
Merged

[FIX] Local Account login error when both LDAP and Email 2FA are enabled #18318

sampaiodiego merged 2 commits into from
Jul 21, 2020

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Jul 21, 2020

Proposed changes

Issue(s)

If LDAP is enabled and you try to login with a non-LDAP password account that has email 2FA enabled, the window to input the totp code was never shown.

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@pierre-lehnen-rc pierre-lehnen-rc added this to the 3.5.0 milestone Jul 21, 2020
sampaiodiego
sampaiodiego previously approved these changes Jul 21, 2020
View reviewed changes
@sampaiodiego sampaiodiego merged commit 163293e into develop Jul 21, 2020
@sampaiodiego sampaiodiego deleted the fix.ldap-local-2fa-login branch July 21, 2020 02:39
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pierre-lehnen-rc @sampaiodiego