Skip to content

Regression: Account Sidebar not rendering properly #18288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 1 commit into from
Jul 17, 2020
Merged

Regression: Account Sidebar not rendering properly #18288

ggazzo merged 1 commit into from
Jul 17, 2020

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jul 17, 2020

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo changed the title [FIX] Account Sidebar not rendering properly Regression: Account Sidebar not rendering properly Jul 17, 2020
@ggazzo ggazzo merged commit 1b31cb6 into develop Jul 17, 2020
@ggazzo ggazzo deleted the fix/sidebarNotRendering branch July 17, 2020 18:51
gabriellsh added a commit that referenced this pull request Jul 17, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into rewr…
55a684f 
…ite/webdav

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Fix sticky notifications not working  (#18285)
  Regression: Account Sidebar not rendering properly (#18288)
  Regression - Profile page crashing for users without password  (#18287)
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabriellsh @ggazzo