[NEW] Enterprise tags #18276
Merged
[NEW] Enterprise tags #18276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tassoevan
force-pushed
the
enterprise-tag
branch
from
fc5ba09 to
8abf038
Compare
tassoevan
requested changes
Jul 16, 2020
client/components/basic/PlanTag.js
Outdated
|
|
||
| useMemo(() => { | ||
| const loadTags = async () => { | ||
| setPlans(await getTags()); |
Contributor
There was a problem hiding this comment.
There's a catch here: setPlans can be accidentally called after the component was unmounted, i.e., PlanTag may be already unmounted after the getTags() returned promise was resolved. To avoid that we usually do some kind of semaphore to skip the setPlans calls after unmount, but I've made a custom hook for that:
import { useSafely } from '@rocket.chat/fuselage-hooks';
const [plans, setPlans] = useSafely(useState([]));So setPlans can be called anytime.
N.B.: Pay attention to possible memory leaks, tough. If the promise never resolves, setPlans will be referenced forever, and the whole component as well.
Co-authored-by: Tasso Evangelista <[email protected]>
Co-authored-by: Tasso Evangelista <[email protected]>
|
This pull request introduces 3 alerts when merging fb443fe into f2ef91d - view on LGTM.com new alerts:
|
sampaiodiego
added a commit
that referenced
this pull request
Jul 17, 2020
This reverts commit 96c21d8.
sampaiodiego
added a commit
that referenced
this pull request
Jul 17, 2020
From #18276 Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Martin Schoeler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this branch https://github.com/RocketChat/Rocket.Chat/pull/18093/files