-
Notifications
You must be signed in to change notification settings - Fork 13.1k
[NEW] OAuth groups to channels mapping #18146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sampaiodiego
merged 13 commits into
RocketChat:develop
from
arminfelder:feature/OpenIDGroupsMapping
Oct 25, 2020
Merged
[NEW] OAuth groups to channels mapping #18146
sampaiodiego
merged 13 commits into
RocketChat:develop
from
arminfelder:feature/OpenIDGroupsMapping
Oct 25, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a39be8 to
8733ef9
Compare
Contributor
|
@pierre-lehnen-rc @sampaiodiego @arminfelder any news to get this PR moving? Any blocker? Thanks a lot @arminfelder, this is a useful feature :) |
Contributor
|
We are using this patch in a production environment - it works like a charm. Please integrate upstream. |
|
Any feedback on pushing it upstream please? |
pierre-lehnen-rc
requested changes
Oct 20, 2020
Co-authored-by: pierre-lehnen-rc <[email protected]>
Co-authored-by: pierre-lehnen-rc <[email protected]>
pierre-lehnen-rc
approved these changes
Oct 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the option to map oauth groups to rocketchat channels, in a similar way it is already possible for LDAP
#Closes RocketChat/feature-requests#360