Skip to content

[FIX] Omnichannel close room callback returning promise #18102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renatobecker merged 2 commits into from
Jul 1, 2020
Merged

[FIX] Omnichannel close room callback returning promise #18102

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca53e2b
Handle callback returning promise.
renatobecker Jul 1, 2020
090aa04
Merge branch 'develop' into omnichannel/fix-callback-returning-promise
renatobecker Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/livechat/server/lib/Livechat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ export const Livechat = {
*/
Apps.getBridges().getListenerBridge().livechatEvent(AppEvents.ILivechatRoomClosedHandler, room);
Apps.getBridges().getListenerBridge().livechatEvent(AppEvents.IPostLivechatRoomClosed, room);
callbacks.run('livechat.closeRoom', room);
callbacks.runAsync('livechat.closeRoom', room);
});

return true;
Expand Down