Regression: Improve Omnichannel Business Hours #18050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
June 24, 2020 20:54
Contributor
renatobecker
left a comment
renatobecker
left a comment
There was a problem hiding this comment.
Initial review. I'm still testing the new implementation.
app/livechat/client/views/app/business-hours/livechatBusinessHoursForm.js
Outdated
Show resolved
Hide resolved
renatobecker
requested changes
Jun 26, 2020
renatobecker
requested changes
Jun 26, 2020
renatobecker
previously approved these changes
Jun 28, 2020
renatobecker
previously approved these changes
Jun 29, 2020
Contributor
|
I didn’t merge the PR yet because @sampaiodiego is assigned as a reviewer also, but it LGTM and ready to merge. |
|
This pull request introduces 2 alerts when merging 254488f into 6f3fc56 - view on LGTM.com new alerts:
|
sampaiodiego
requested changes
Jun 29, 2020
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
can we fix the two alerts from LGTM pls? https://lgtm.com/projects/g/RocketChat/Rocket.Chat/rev/pr-f867e7a0996c2a39bad4290bd1650b307b8b4b13
sampaiodiego
approved these changes
Jun 29, 2020
sampaiodiego
changed the title
gabriellsh
added a commit
that referenced
this pull request
Jun 30, 2020
…ocket.Chat into new/rewrite_account_profile * 'new/account_sidebar_rewrite' of github.com:RocketChat/Rocket.Chat: Fix sidenav close Regresion: Issue with reply button on broadcast channels (#18057) Regression: Infinite render loop on Setup Wizard (#18074) Regression: Improve Omnichannel Business Hours (#18050) Regression: Fix threads badge color indicators (#18048) Regression: Improve the logic to get request IPs (#18033)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments