Skip to content

Regression: Fix wrong message grouping inside threads #18039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 1 commit into from
Jun 25, 2020
Merged

Regression: Fix wrong message grouping inside threads #18039

sampaiodiego merged 1 commit into from
Jun 25, 2020

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 25, 2020 •
edited
Loading

Proposed changes

Inside threads the first message was always grouping

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo added this to the 3.4.0 milestone Jun 25, 2020
@sampaiodiego sampaiodiego changed the title Regression: Fix wrong message grouping Regression: Fix wrong message grouping inside threads Jun 25, 2020
@sampaiodiego sampaiodiego merged commit 49183a8 into develop Jun 25, 2020
@sampaiodiego sampaiodiego deleted the regression/groupping branch June 25, 2020 03:45
ggazzo added a commit that referenced this pull request Jun 25, 2020
@ggazzo
Revert "Regression: Fix wrong message grouping inside threads (#18039)"
9a28fb4 
This reverts commit 49183a8.
@ggazzo ggazzo mentioned this pull request Jun 25, 2020
Merged
ggazzo added a commit that referenced this pull request Jun 25, 2020
@ggazzo
Revert "Regression: Fix wrong message grouping inside threads (#18039)…
a2323bf 
…" (#18043)

This reverts commit 49183a8.
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ggazzo @sampaiodiego