Skip to content

[FIX] Corrects Typo in Analytics section of the admin page #17984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 3 commits into from
Jun 30, 2020
Merged

[FIX] Corrects Typo in Analytics section of the admin page #17984

ggazzo merged 3 commits into from
Jun 30, 2020

Conversation

@darigovresearch
Copy link
Contributor

@darigovresearch darigovresearch commented Jun 21, 2020

Proposed changes

Small typo correction to text in two i18n.json files

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ggazzo ggazzo added this to the 3.5.0 milestone Jun 22, 2020
@ggazzo ggazzo changed the title [FIX]: Corrects Typo in Analytics section of the admin page [FIX] Corrects Typo in Analytics section of the admin page Jun 30, 2020
@ggazzo ggazzo merged commit 92d6a40 into RocketChat:develop Jun 30, 2020
dudizilla added a commit that referenced this pull request Jun 30, 2020
@dudizilla
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
adb97b7 
…nto fix/prune_discussions

* 'develop' of https://github.com/RocketChat/Rocket.Chat: (47 commits)
  [FIX] Corrects Typo in Analytics section of the admin page (#17984)
  Bump version to 3.5.0-develop
  Bump version to 3.4.0
  Bump version to 3.4.0-rc.5
  Regression: Fix update last message on delete (#18077)
  Bump version to 3.4.0-rc.4
  Regression: Wrong padding and colors on some tabs (#18068)
  Regression: Fix mentions on thread preview (#18071)
  Upgrade Livechat Widget version to 1.6.0 (#18070)
  Regression: Fix exit-room on livechat (#18067)
  Regresion: Issue with reply button on broadcast channel
  ...
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@darigovresearch @CLAassistant @ggazzo