Skip to content

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Jun 19, 2020

Proposed changes

Fix an issue where the page was not rendering after opening the user edit screen.

Issue(s)

How to test or reproduce

As an admin, try to edit an user data when there's no custom fields configured.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@pierre-lehnen-rc pierre-lehnen-rc added this to the 3.4.0 milestone Jun 19, 2020
@ggazzo ggazzo merged commit 7a5433c into develop Jun 20, 2020
@ggazzo ggazzo deleted the fix.admin-user-edit branch June 20, 2020 17:15
@pierre-lehnen-rc
Copy link
Contributor Author

The "fix review" commit broke the page again.
#17992 fixes it

@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants