Skip to content

Conversation

@sampaiodiego
Copy link
Member

Proposed changes

Validate user permissions before creating jitsi video conferences.

Issue(s)

Closes #17021
Closes #16905
Closes #9983

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

Need to update the API documentation.

@sampaiodiego sampaiodiego added the documentation: needed Needs addition/changes to documentation label Jun 18, 2020
@sampaiodiego sampaiodiego added this to the 3.4.0 milestone Jun 18, 2020
@sampaiodiego sampaiodiego requested a review from ggazzo June 18, 2020 13:45
@engelgabriel
Copy link
Member

Can you look at #17950 to merge it together?

ggazzo
ggazzo previously approved these changes Jun 19, 2020
@ggazzo ggazzo merged commit 7db530c into develop Jun 19, 2020
@ggazzo ggazzo deleted the validate-permissions-to-create-video-calls branch June 19, 2020 05:38
@ankar84
Copy link

ankar84 commented Jun 19, 2020

@sampaiodiego I see that PR have a lot improvements of JitsiTimeout, so can that PR fix #11649 somehow?

@sampaiodiego
Copy link
Member Author

I don't think so @ankar84 .. we might need to do a deeper look to solve #11649

@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation: needed Needs addition/changes to documentation

Projects

None yet

5 participants