Skip to content

[IMPROVE] User avatar cache invalidation #17925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 9 commits into from
Jun 19, 2020
Merged

[IMPROVE] User avatar cache invalidation #17925

ggazzo merged 9 commits into from
Jun 19, 2020

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Jun 16, 2020 •
edited
Loading

Proposed changes

Every time an avatar is changed, we store the file etag on the user's document. Then return this etag with the user data on every API so that when the client requests the user's avatar, it can include the etag on the request.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@rodrigok rodrigok added this to the 3.4.0 milestone Jun 17, 2020
@sampaiodiego sampaiodiego self-assigned this Jun 18, 2020
@sampaiodiego sampaiodiego changed the title [NEW] Store and use avatar ETag to manage cache [IMPROVE] User avatar cache invalidation Jun 19, 2020
@ggazzo ggazzo merged commit d4d4002 into develop Jun 19, 2020
@ggazzo ggazzo deleted the avatar-cache branch June 19, 2020 05:37
@sampaiodiego sampaiodiego mentioned this pull request Jun 19, 2020
Closed
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
@djorkaeffalexandre djorkaeffalexandre mentioned this pull request Jul 9, 2020
Closed
@sampaiodiego sampaiodiego mentioned this pull request Jul 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

@sampaiodiego sampaiodiego

Labels

None yet

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@pierre-lehnen-rc @ggazzo @sampaiodiego @rodrigok