Skip to content

Conversation

@toshokan
Copy link
Contributor

@toshokan toshokan commented Jun 7, 2020

Proposed changes

Don't have a typo

Issue(s)

There was a typo in the word corresponding, it was spelled "coorosponding"

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Changelog

Fix typo on English LDAP page

Further comments

@toshokan
Copy link
Contributor Author

toshokan commented Jun 7, 2020

Just noting that the CI failure is unrelated to the change

@toshokan
Copy link
Contributor Author

@ggazzo @rodrigok I noticed you had reviewed simple typo PRs before, mind taking a look?
Thanks!

@ggazzo ggazzo merged commit 63c5c4f into RocketChat:develop Jun 18, 2020
gabriellsh added a commit that referenced this pull request Jun 18, 2020
…into new/apps_rewrite_local

* 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat:
  [FIX] Typo "coorosponding" (#17840)
  Regression: Infinite loop in CodeSettingInput (#17949)
  [NEW][ENTERPRISE] Download engagement data (#17920)
  [FIX] Hide system message add/remove owner  (#17938)
ggazzo added a commit that referenced this pull request Jun 18, 2020
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  [FIX] Typo "coorosponding" (#17840)
  Regression: Infinite loop in CodeSettingInput (#17949)
  [NEW][ENTERPRISE] Download engagement data (#17920)
  [FIX] Hide system message add/remove owner  (#17938)
  [IMPROVE] Performance editing Admin settings (#17916)
  [IMPROVE] React hooks lint rules (#17941)
  [FIX] StreamCast stream to server only streamers (#17942)
  [FIX] Profile save button not activates properly when changing the username field (#16541)
  [FIX] Outgoing webhook: Excessive spacing between trigger words (#17830)
  [FIX] Links being escaped twice leading to visible encoded characters (#16481)
  [NEW][API] New endpoints to manage User Custom Status `custom-user-status.create`, custom-user-status.delete` and `custom-user-status.update` (#16550)
  [FIX] Message action popup doesn't adjust itself on screen resize (#16508)
  [FIX] Not possible to translate the label of custom fields in user's Info (#15595)
  [FIX] Close the user info context panel does not navigate back to the user's list (#14085)
  [FIX] Missing pinned icon indicator for messages pinned (#16448)
  Chatpal: limit results to current room (#17718)
  Do not build Docker image for fork PRs (#17370)
  [IMPROVE] Use REST for DDP calls by default (#17934)
  [IMPROVE] Add rate limiter to UiKit endpoints (#17859)
  LingoHub based on develop (#17796)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants