Skip to content

[FIX] Administration User page blank opening users without email #17836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 1 commit into from
Jun 5, 2020
Merged

[FIX] Administration User page blank opening users without email #17836

ggazzo merged 1 commit into from
Jun 5, 2020

Conversation

@dudizilla
Copy link
Contributor

@dudizilla dudizilla commented Jun 5, 2020 •
edited
Loading

Proposed changes

Issue(s)

Closes #17806

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo added this to the 3.3.1 milestone Jun 5, 2020
@ggazzo ggazzo changed the title [FIX] Blank UI when users without email [FIX] Administration User page blank opening users without email Jun 5, 2020
@ggazzo ggazzo merged commit e01297c into develop Jun 5, 2020
@ggazzo ggazzo deleted the resolving-blank-ui branch June 5, 2020 22:47
ggazzo added a commit that referenced this pull request Jun 8, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
f388313 
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Administration User page blank opening users without email (#17836)
  [REGRESSION] Omnichannel visitor forward was applying wrong restrictions (#17826)
  [NEW] Assign oldest active user as owner when deleting last room owner (#16088)
@sampaiodiego sampaiodiego mentioned this pull request Jun 10, 2020
Merged
sampaiodiego pushed a commit that referenced this pull request Jun 10, 2020
@dudizilla @sampaiodiego
[FIX] Administration User page blank opening users without email (#17836
9e04e14 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3.1

Development

Successfully merging this pull request may close these issues.

BUG: As admin, I cannot open the "users" interface if there are users with blank emails

3 participants

@dudizilla @ggazzo