Skip to content

Conversation

@MarcosSpessatto
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto commented Jun 4, 2020

Proposed changes

The old Office Hours feature was checking the state of the Office Hours(open/close) every minute(setInterval). Through this refactoring, we're going to improve the process, now we're scheduling the opening/closing process as crontab jobs, so the setInterval is gone.
Also, we replaced the old rocketchat_livechat_office_hour collection by a new data structure, the new collection is called rocketchat_livechat_business_hours.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

  • Improved the process of opening/closing Office Hours. Now the new Business Hours are scheduled as Crontab jobs
  • Replaced the old rocketchat_livechat_office_hour collection to a new data structure called rocketchat_livechat_business_hours
  • Renamed the old feature from Office Hours to Business Hours
  • Migrated the old Office Hours configuration to the new data structure

Further comments

@MarcosSpessatto MarcosSpessatto added this to the 3.4.0 milestone Jun 16, 2020
@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review June 16, 2020 18:40
Copy link
Contributor

@renatobecker renatobecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcosSpessatto congrats, it's an amazing implementation.
Can you please fix the conflict? Then I'll review it over.

Thanks.

@renatobecker renatobecker changed the title [IMPROVE] Refactor Omnichannel business hours [IMPROVE] Refactor Omnichannel Office Hours feature Jun 21, 2020
@renatobecker renatobecker merged commit 6c2f4ff into develop Jun 21, 2020
@renatobecker renatobecker deleted the improvements/refactor-livechat-office-hours branch June 21, 2020 02:45
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
@rodrigok rodrigok changed the title [IMPROVE] Refactor Omnichannel Office Hours feature [IMPROVE][Omnichannel] Refactor Office Hours feature Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants