-
Notifications
You must be signed in to change notification settings - Fork 13.1k
[IMPROVE][Omnichannel] Refactor Office Hours feature #17824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
renatobecker
merged 39 commits into
develop
from
improvements/refactor-livechat-office-hours
Jun 21, 2020
Merged
[IMPROVE][Omnichannel] Refactor Office Hours feature #17824
renatobecker
merged 39 commits into
develop
from
improvements/refactor-livechat-office-hours
Jun 21, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatobecker
requested changes
Jun 17, 2020
Contributor
renatobecker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcosSpessatto congrats, it's an amazing implementation.
Can you please fix the conflict? Then I'll review it over.
Thanks.
app/livechat/client/views/app/business-hours/livechatBusinessHoursForm.js
Outdated
Show resolved
Hide resolved
12 tasks
…ffice-hours' into improvements/refactor-livechat-office-hours
renatobecker
requested changes
Jun 19, 2020
…ffice-hours' into improvements/refactor-livechat-office-hours
renatobecker
approved these changes
Jun 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The old Office Hours feature was checking the state of the Office Hours(open/close) every minute(setInterval). Through this refactoring, we're going to improve the process, now we're scheduling the opening/closing process as
crontab jobs, so the setInterval is gone.Also, we replaced the old
rocketchat_livechat_office_hourcollection by a new data structure, the new collection is calledrocketchat_livechat_business_hours.Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
rocketchat_livechat_office_hourcollection to a new data structure calledrocketchat_livechat_business_hoursOffice HourstoBusiness HoursFurther comments