Skip to content

Add Apps to control GitHub issues #17807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rodrigok merged 9 commits into from
Jun 18, 2020
Merged

Add Apps to control GitHub issues #17807

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c37dcbe
Remove custom issue template
sampaiodiego Jun 2, 2020
e2492ef
Add stale app config
sampaiodiego Jun 2, 2020
bc700b0
Add no response app config
sampaiodiego Jun 2, 2020
1af69eb
Add isse close app config
sampaiodiego Jun 2, 2020
f919d9b
Add comment
sampaiodiego Jun 2, 2020
ae01804
Use github actions for stale issues
sampaiodiego Jun 2, 2020
c9a9aa8
Change to 60 days
sampaiodiego Jun 3, 2020
1f7e5ae
Merge branch 'develop' into add-apps-control-issues
sampaiodiego Jun 17, 2020
a91f446
Apply suggestions from code review
sampaiodiego Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/ISSUE_TEMPLATE/custom.md
View file
Open in desktop

This file was deleted.

17 changes: 17 additions & 0 deletions .github/issue-close.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Config for Close Issue app: https://probot.github.io/apps/close-issue/

# Comment that will be sent if an issue is judged to be closed
comment: "This issue is closed because it does not meet any of our issue templates. Please make sure to use it."
Comment thread
sampaiodiego marked this conversation as resolved.
Outdated
issueConfigs:
# There can be several configs for different kind of issues.
- content:
# Bug report
- "Steps to reproduce"
- "Expected behavior"
- "Actual behavior"
- "Version of Rocket.Chat Server"
- content:
# Release issue
- "Before Release - Preparation"
# The issue is judged to be legal if it includes all keywords from any of these two configs.
Comment thread
sampaiodiego marked this conversation as resolved.
Outdated
# Or it will be closed by the app.
36 changes: 36 additions & 0 deletions .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: Stale Questions

on:
schedule:
- cron: "0 0 * * *"

jobs:
stale:
runs-on: ubuntu-latest

steps:
- uses: actions/stale@v2
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-stale: 10
days-before-close: 4

@engelgabriel engelgabriel Jun 9, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those numbers are far too short. If we are moving from having no automation to having those date limits, we should start being A LOT more flexible with the dates, and gradually decrease the time limits as we fine-tune the process.

@rodrigok rodrigok Jun 9, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's after adding the label stat: need more info. Do you think it should be more than 14 days @engelgabriel ?

@sampaiodiego sampaiodiego Jun 9, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think two weeks is too aggressive to the close an issue AFTER an interaction.. and again, it will receive a new comment from the bot after 10 days in case the owner misses the notification from first interaction.. it will be closed after 4 days after the second interaction..

I'm not saying those are the right numbers. I'm just explaining exactly what will happen.. also I found other repos using the same params and found them reasonable. do you have something else in mind?

@ggazzo ggazzo Jun 9, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IF.. I said... IF an user opened an issue and we answered/asked in time...7 days is enough time to interact again... I mean, the user should be more interested than us to solve his problem and probably he is waiting for some reply...

@Sing-Li Sing-Li Jun 9, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be at least longer than the Brazilian mandatory vacations days duration.

only-labels: 'stat: need more info'
stale-issue-message: >-
This issue has been marked as stale because there has been
no further activity in the last 10 days. If the issue remains
stale for the next 4 days (a total of two weeks with no activity),
then it will be assumed that the question has been resolved and
the issue will be automatically closed.
stale-issue-label: 'stat: no response'

- uses: actions/stale@v2
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-stale: 60
days-before-close: 7
exempt-issue-labels: 'Epic,Feature: Planned,sla,sponsored,stat: waiting PR merge,Triaged,subj: security'
stale-issue-message: >-
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.
stale-issue-label: 'stat: stale'