Skip to content

[FIX] Slack importer settings object #17776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 1 commit into from
Jun 9, 2020
Merged

[FIX] Slack importer settings object #17776

sampaiodiego merged 1 commit into from
Jun 9, 2020

Conversation

@lpilz
Copy link
Contributor

@lpilz lpilz commented May 28, 2020 •
edited by sampaiodiego
Loading

Proposed changes

Fixes the import of the settings object in the slack importer. Prerequisite for #17637

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Changelog

Fixes import of settings object in slack importer.

@lpilz lpilz mentioned this pull request May 28, 2020
Merged
@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 1 alert when merging 192695a into 0d2723f - view on LGTM.com

fixed alerts:

  • 1 for Property access on null or undefined

@engelgabriel engelgabriel added this to the 3.4.0 milestone Jun 2, 2020
@TemaSM TemaSM mentioned this pull request Jun 5, 2020
Closed
4 tasks
TemaSM
TemaSM approved these changes Jun 5, 2020
View reviewed changes
Copy link

@TemaSM TemaSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@TemaSM
Copy link

TemaSM commented Jun 8, 2020

Another Slack's importer issue: #17855

@pierre-lehnen-rc pierre-lehnen-rc modified the milestones: 3.4.0, 3.3.1 Jun 8, 2020
@sampaiodiego sampaiodiego merged commit 6828007 into RocketChat:develop Jun 9, 2020
@lpilz
Copy link
Contributor Author

lpilz commented Jun 9, 2020

@TemaSM I don't quite understand your comment. Do you mean to say that this PR also fixes #17855? How are they related?

@TemaSM
Copy link

TemaSM commented Jun 9, 2020 •
edited
Loading

No, this PR not fixing another issue.
Just left comment for authors & contributors to escalate their attention to major problem related to Slack importer, to fix it asap. Because it's a blocker for newcomers, who moves from Slack, like me & my team

ggazzo added a commit that referenced this pull request Jun 9, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
859a782 
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Importers progress sending too much update events to clients (#17857)
  [FIX] Omnichannel message link is broken in email notifications (#17843)
  [FIX] Logic for room type was inverted in edit panel (#17851) (#17853)
  Refactor components and views to Storybook compatibility (#17800)
  [FIX] Slack importer settings object (#17776)
  Create codeql-analysis.yml
@sampaiodiego sampaiodiego mentioned this pull request Jun 10, 2020
Merged
sampaiodiego pushed a commit that referenced this pull request Jun 10, 2020
@lpilz @sampaiodiego
[FIX] Slack importer settings object (#17776)
aedce8c
@lpilz lpilz deleted the fix/slack-importer-settings branch June 10, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierre-lehnen-rc pierre-lehnen-rc pierre-lehnen-rc approved these changes

+1 more reviewer

@TemaSM TemaSM TemaSM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3.1

Development

Successfully merging this pull request may close these issues.

5 participants

@lpilz @TemaSM @pierre-lehnen-rc @engelgabriel @sampaiodiego