Skip to content

Conversation

@shiqimei
Copy link
Contributor

@shiqimei shiqimei commented May 25, 2020

Proposed changes

https://app.asana.com/0/633285093795758/1177305720214377/f

Issue(s)

N/A

How to test or reproduce

  • Install any of apps here (private repo)
  • Turn on Game Center experimental feature in the Admin -> General -> Apps
  • Open the game in the game center
  • Check Admin -> View Logs or logs from terminal to see if avatarUrl's value correct

Screenshots

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@shiqimei shiqimei requested a review from d-gubert May 25, 2020 15:31
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@shiqimei shiqimei requested a review from ggazzo May 26, 2020 16:25
@ggazzo ggazzo merged commit ab994fb into develop Jun 19, 2020
@ggazzo ggazzo deleted the fix-game-center-double-slashes branch June 19, 2020 04:01
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants