Add translation var #17614
Closed
Add translation var #17614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@gabriellsh / @sampaiodiego - Is there anything that needs changed for this PR to land? It seems quite simple and honestly quite discouraging that it's been sitting here this long while other fixes seem to get to the front of the line. |
Author
|
This seems to have been merged at this point under this - #18002 - which again brings up the point of this being discouraging for others that are trying to contribute. |
Member
|
I'm really sorry to hear that @AgentTNT .. as you can see on our latest release we have a huge list of contributors, but sometimes it happens that we don't see all PRs 😞 hope you understand and keep contributing, even opening or commenting in issues as I have seen you already, that also helps us a lot! thanks =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds translation var for this:
