Skip to content

[FIX] SAML IDP initiated logout error #17482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 1 commit into from
May 22, 2020
Merged

[FIX] SAML IDP initiated logout error #17482

sampaiodiego merged 1 commit into from
May 22, 2020

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Apr 29, 2020

Closes #17439

linscombe
linscombe reviewed May 4, 2020
View reviewed changes
Copy link

@linscombe linscombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to confirm that this fixes the problem however I am not able to properly build a local docker image to test with. I don't see an official guide for that so I have been using the following steps. Is this correct?

git clone https://github.com/RocketChat/Rocket.Chat
cd Rocket.Chat
meteor npm i
meteor build --server-only --directory /tmp/rc-build
cp .docker/Dockerfile /tmp/rc-build
cd /tmp/rc-build
docker build -t rocketchat/rocket.chat:fix .

@sampaiodiego
Copy link
Member

sampaiodiego commented May 14, 2020

that's correct @linscombe

@cb3inco
Copy link

cb3inco commented May 21, 2020

@sampaiodiego - Are you waiting on @linscombe to test this? Was hoping this would be merged into the next release (I see RC 3.30 (release candidate) was pushed a few hours ago). We are waiting on this to be resolved so we can roll RocketChat to our users.

@sampaiodiego
Copy link
Member

sampaiodiego commented May 22, 2020

no, I actually lost track of this PR to merge before cutting the release candidate.

but we'll go ahead and merge this during rc since it's a small and important fix.

@sampaiodiego sampaiodiego merged commit ccf6e27 into develop May 22, 2020
@sampaiodiego sampaiodiego deleted the fix.saml-idp-initiated-logout-2 branch May 22, 2020 14:12
@linscombe
Copy link

linscombe commented May 22, 2020

thanks @sampaiodiego and @pierre-lehnen-rc for the fix!

This was referenced May 28, 2020
Merged
Merged
gabriellsh added a commit that referenced this pull request May 29, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
b152498 
…apps_rewrite

* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits)
  Regression: Fix Unread bar design (#17750)
  Regression: Adjusting spaces between OAuth login buttons (#17745)
  Improved thread margins for clarity
  Regression: Scroll on admin user info (#17711)
  Regression: Removed status border on mentions list (#17741)
  Regression: Force unread-rooms bar to appears over the room list (#17728)
  [NEW][APPS-ENGINE] Essentials mechanism (#17656)
  Regression: Fix error preventing creation of group DMs (#17726)
  [FIX] SAML IDP initiated logout error (#17482)
  Regression: Threads list was fetching all threads (#17716)
  Regression: Add missing return to afterSaveMessage callbacks (#17715)
  [FIX] Missing dropdown to select custom status color on user's profile (#16537)
  [FIX] Password reset/change accepting current password as new password (#16331)
  [NEW][ENTERPRISE] Support Omnichannel conversations auditing (#17692)
  Upgrade Livechat Widget version to 1.5.0 (#17710)
  [FIX] Can't click on room's actions menu of sidebar list when in search mode (#16548)
  [NEW][ENTERPRISE] Support for custom Livechat registration form fields (#17581)
  Update Fuselage version (#17708)
  [NEW][ENTERPRISE] Omnichannel Last-Chatted Agent Preferred option (#17666)
  Regression: Status presence  color (#17707)
  ...
ggazzo added a commit that referenced this pull request Jun 3, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
e38a519 
…/new-threads* 'develop' of github.com:RocketChat/Rocket.Chat: (54 commits) Submit a payload to the release service when a release happens (#17775)  Regression: Fix Unread bar design (#17750)  Regression: Adjusting spaces between OAuth login buttons (#17745)  Improved thread margins for clarity  Regression: Scroll on admin user info (#17711)  Regression: Removed status border on mentions list (#17741)  Regression: Force unread-rooms bar to appears over the room list (#17728)  [NEW][APPS-ENGINE] Essentials mechanism (#17656)  Regression: Fix error preventing creation of group DMs (#17726)  [FIX] SAML IDP initiated logout error (#17482)  Regression: Threads list was fetching all threads (#17716)  Regression: Add missing return to afterSaveMessage callbacks (#17715)  [FIX] Missing dropdown to select custom status color on user's profile (#16537)  [FIX] Password reset/change accepting current password as new password (#16331)  [NEW][ENTERPRISE] Support Omnichannel conversations auditing (#17692)  Upgrade Livechat Widget version to 1.5.0 (#17710)  [FIX] Can't click on room's actions menu of sidebar list when in search mode (#16548)  [NEW][ENTERPRISE] Support for custom Livechat registration form fields (#17581)  Update Fuselage version (#17708)  [NEW][ENTERPRISE] Omnichannel Last-Chatted Agent Preferred option (#17666)  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

+1 more reviewer

@linscombe linscombe linscombe left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Idp initiated SAML Logout - Cannot read property 'childNodes' of undefined

5 participants

@pierre-lehnen-rc @sampaiodiego @cb3inco @linscombe