Skip to content

[IMPROVE] Depart from /app/ui-admin #17464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 22 commits into from
Apr 29, 2020
Merged

[IMPROVE] Depart from /app/ui-admin #17464

ggazzo merged 22 commits into from
Apr 29, 2020

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Apr 28, 2020 •
edited
Loading

  • Moves code from /app/ui-admin to /client/admin
  • Standardizes markdown usage
  • Uses development version of Fuselage
  • Split Users and Rooms
  • Remove unused hooks and components

@tassoevan tassoevan changed the title ... Depart from /app/ui-admin Apr 28, 2020
@tassoevan tassoevan requested a review from a team April 28, 2020 20:05
@tassoevan tassoevan added the area: ui Touches the code on client side label Apr 28, 2020
@tassoevan tassoevan marked this pull request as ready for review April 29, 2020 18:37
@lgtm-com
Copy link

lgtm-com bot commented Apr 29, 2020

This pull request introduces 5 alerts when merging fd15392 into a26700c - view on LGTM.com

new alerts:

  • 5 for Property access on null or undefined

@ggazzo ggazzo changed the title Depart from /app/ui-admin [IMPROVE] Depart from /app/ui-admin Apr 29, 2020
@ggazzo ggazzo merged commit 43a8649 into admin-refactor Apr 29, 2020
@ggazzo ggazzo deleted the adm/move-to-client branch April 29, 2020 20:19
ggazzo added a commit that referenced this pull request Apr 29, 2020
@ggazzo
Merge branch 'admin-refactor' of github.com:RocketChat/Rocket.Chat in…
f68d969 
…to adminUsers_actions* 'admin-refactor' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Depart from /app/ui-admin (#17464)
dudizilla added a commit that referenced this pull request May 4, 2020
@dudizilla
Merge branch 'admin-refactor' of https://github.com/RocketChat/Rocket…
20ebb2b 
….Chat into custom-emoji

* 'admin-refactor' of https://github.com/RocketChat/Rocket.Chat:
  LingoHub based on develop (#17520)
  RegExp improvements suggested by LGTM (#17500)
  [FIX] Replace obsolete X-FRAME-OPTIONS header on Livechat route (#17419)
  [FIX] LDAP login error on Enterprise version (#17497)
  [IMPROVE] [Apps-Engine] App user as the default notifier (#17050)
  [NEW] [Apps-Engine] New Livechat event handlers (#17033)
  [FIX] Change email verification label (#17450)
  fix: Admin Users Actions (#17469)
  Fix bad component reference
  [IMPROVE] Depart from /app/ui-admin (#17464)
  Priority system messages were always created (#17479)
  Bump version to 3.3.0-develop
  Bump version to 3.2.0
  Bump version to 3.2.0-rc.2
  Bump version to 3.2.0-rc.1
  Bump version to 3.2.0-rc.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area: ui Touches the code on client side

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tassoevan @ggazzo