[NEW] feat(CAS): Adding option to enable/disable user creation from CAS auth #17154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
Is there a specific way to provide more i18n translations or is it good like that ? |
jgribonvald
force-pushed
the
feat_CAS_User_Creation_option
branch
2 times, most recently
from
00d9b59 to
fb0b71b
Compare
Contributor
Author
|
Hi, |
This was referenced Apr 9, 2020
jgribonvald
force-pushed
the
feat_CAS_User_Creation_option
branch
from
eab21c6 to
f92d326
Compare
Contributor
Author
|
A little refresh on this PR! What do you think about it ? |
|
Agreed, it would be very useful ! |
pierre-lehnen-rc
requested changes
Jul 20, 2020
jgribonvald
force-pushed
the
feat_CAS_User_Creation_option
branch
from
f92d326 to
0f1acbe
Compare
Contributor
Author
|
All requested change were applied ! |
pierre-lehnen-rc
approved these changes
Jul 21, 2020
Contributor
Author
|
Is this PR could be merged now ? as it pass all test and it was approved ? |
Contributor
|
Sorry we somehow missed it when cutting the release. I'll make sure it gets merged as soon as the current feature freeze is over. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17153 and feature request
As simple as it is, this feature permit to make optional the user creation when a user come from a CAS authentication. The use case is that the user is imported before from on other source and so should exist. It permit also to filter user access.