Skip to content

[FIX] Elements of "Personal Access Tokens" section out of alignment and unusable on very small screens #17129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rodrigok merged 3 commits into from
May 20, 2020
Merged

[FIX] Elements of "Personal Access Tokens" section out of alignment and unusable on very small screens #17129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
560ac74
Update width in media query
Nikhil713 Apr 2, 2020
9e961f4
Fix the preferences page
Nikhil713 Apr 3, 2020
c2e6fc7
Merge branch 'develop' into personalaccesstoken
engelgabriel May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions app/theme/client/imports/general/base_old.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1495,6 +1495,15 @@ rc-old select,
border-bottom: none;
}

& .add-token {
display: flex;

& .rc-select {
width: 40%;
margin: 0 0 0 10px;
}
}

&:first-child {
padding-top: 0;
}
Expand Down Expand Up @@ -4978,6 +4987,15 @@ rc-old select,
display: none;
}
}

.add-token {
display: block !important;

& .rc-select {
width: auto !important;
margin: 10px 0 !important;
}
}
}

@media (width <= 500px) {
Expand Down
4 changes: 2 additions & 2 deletions imports/personal-access-tokens/client/personalAccessTokens.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<div class="section-content border-component-color">
<div class="input-line double-col">
<label for="tokenName" class="setting-label">{{_ "API_Personal_Access_Tokens_To_REST_API"}}</label>
<div style="display: flex;">
<div class="add-token">
<div class="setting-field" style="flex-grow: 1;">
<input type="text" class="rc-input__element js-search" name="tokenName" id="tokenName"
placeholder={{_ "API_Add_Personal_Access_Token"}} autocomplete="off" />
Expand All @@ -20,8 +20,8 @@
</select>
{{> icon block="rc-select__arrow" icon="arrow-down"}}
</div>
<button name="add" class="rc-button rc-button--primary setting-action save-token">{{_ "Add"}}</button>
</div>
<button name="add" class="rc-button rc-button--primary setting-action save-token">{{_ "Add"}}</button>
</div>
</div>
</form>
Expand Down