[FIX] Star icon is visible when you hover over message #16461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegeta999
force-pushed
the
starred_icon
branch
from
84775e8 to
09041d1
Compare
Contributor
Author
|
@ggazzo please review ! |
|
|
rodrigok
changed the title
Member
|
we need to compare to #16445 |
Member
|
I'll close this PR in favor of #16661, as there is no need to hide de star. Thanks for the help anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Solution:
Star appears when you hover over message. Consider the situation when all messages are starred and edited the whole page would be redundantly filled with stars and pencil icons.
That's why I propose that star should be visible when you hover over it.
Fixes #16383