Skip to content

[NEW] Accept variable #{userdn} on LDAP group filter #16273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rodrigok merged 2 commits into from
May 30, 2020
Merged

[NEW] Accept variable #{userdn} on LDAP group filter #16273

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d6c4bb
added variable userdn to LDAP group filter
ChrissW-R1 Jan 17, 2020
3f2bc49
Merge branch 'develop' into userdn-in-groups
rodrigok May 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/ldap/server/sync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function isUserInLDAPGroup(ldap, ldapUser, user, ldapGroup) {
return false;
}
const searchOptions = {
filter: syncUserRolesFilter.replace(/#{username}/g, user.username).replace(/#{groupName}/g, ldapGroup),
filter: syncUserRolesFilter.replace(/#{username}/g, user.username).replace(/#{groupName}/g, ldapGroup).replace(/#{userdn}/g, ldapUser.dn),
scope: 'sub',
};

Expand Down