Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jan 6, 2020

closes #16238

@tassoevan tassoevan added type: bug area: ui Touches the code on client side labels Jan 6, 2020
@ggazzo ggazzo self-requested a review January 7, 2020 02:57
@lgtm-com
Copy link

lgtm-com bot commented Jan 7, 2020

This pull request introduces 1 alert when merging 7c444a6 into cc34120 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@ggazzo ggazzo marked this pull request as ready for review January 13, 2020 21:30
@ggazzo ggazzo changed the title [FIX] Administration pages performances issues [FIX] Setup Wizard inputs and Admin Settings Jan 13, 2020
@ggazzo ggazzo added this to the 2.4.2 milestone Jan 13, 2020
ggazzo
ggazzo previously approved these changes Jan 13, 2020
@ggazzo ggazzo force-pushed the fix/admin-perf-issues branch from 9a5fa49 to b5221ec Compare January 14, 2020 12:11
@ggazzo ggazzo force-pushed the fix/admin-perf-issues branch from b5221ec to f88bfda Compare January 14, 2020 12:39
@ggazzo ggazzo merged commit 58dbac5 into develop Jan 14, 2020
@ggazzo ggazzo deleted the fix/admin-perf-issues branch January 14, 2020 13:23
dudizilla added a commit that referenced this pull request Jan 14, 2020
…hat into hide-system-messages

* 'hide-system-messages' of github.com:RocketChat/Rocket.Chat:
  [FIX] Setup Wizard inputs and Admin Settings (#16147)
  revert changes
  Add a converter on getting the file buffer from Apps-Engine.
  [FIX] Integrations admin page (#16183)
  adding functions and code refactoring
  renamed multiSelect
  fix lint
  MultiSelect using Fuselage
  Changed Help wanted section (#16197)
gabriellsh added a commit that referenced this pull request Jan 15, 2020
…pinned_messages_collapse

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] The "click to load" text is hard-coded and not translated. (#16142)
  [FIX] Integrations list without pagination and outgoing integration creation (#16233)
  [FIX] Setup Wizard inputs and Admin Settings (#16147)
  Add a converter on getting the file buffer from Apps-Engine.
  [FIX] Integrations admin page (#16183)
  Changed Help wanted section (#16197)
  [IMPROVE] Improve function to check if setting has changed (#16181)
  fix: remove empty custom fields
  perf: replace getCustomFields by REST
  fix: set new custom fields values for livechat
  chore: fix review
  feat(livechat): add validation for custom fields
  strong for Department in VisitorInfo
  Add GUI for customFields in Livechat
  Regression: Enable apps change properties of the sender on the message as before (#16189)
  [FIX] User stuck after reset password (#16184)
gabriellsh added a commit that referenced this pull request Jan 15, 2020
…/custom-emoji-tip

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] The "click to load" text is hard-coded and not translated. (#16142)
  [FIX] Integrations list without pagination and outgoing integration creation (#16233)
  [FIX] Setup Wizard inputs and Admin Settings (#16147)
@sampaiodiego sampaiodiego mentioned this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Allow converting long messages to attachment option dysfunctional

5 participants