Skip to content

[IMPROVE] Make push notification batchsize and interval configurable #15804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 1 commit into from
Nov 21, 2019
Merged

[IMPROVE] Make push notification batchsize and interval configurable #15804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions app/lib/server/startup/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,6 +1160,24 @@ settings.addGroup('Push', function() {
value: true,
},
});
this.add('Push_send_interval', 5000, {
type: 'int',
public: true,
alert: 'Push_Setting_Requires_Restart_Alert',
enableQuery: {
_id: 'Push_enable',
value: true,
},
});
this.add('Push_send_batch_size', 10, {
type: 'int',
public: true,
alert: 'Push_Setting_Requires_Restart_Alert',
enableQuery: {
_id: 'Push_enable',
value: true,
},
});
this.add('Push_enable_gateway', true, {
type: 'boolean',
alert: 'Push_Setting_Requires_Restart_Alert',
Expand Down
4 changes: 3 additions & 1 deletion packages/rocketchat-i18n/i18n/en.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2520,6 +2520,8 @@
"Push_apn_key": "APN Key",
"Push_apn_passphrase": "APN Passphrase",
"Push_debug": "Debug",
"Push_send_interval": "Interval to check the queue for new push notifications",
"Push_send_batch_size": "Batch size to be processed every tick",
"Push_enable": "Enable",
"Push_enable_gateway": "Enable Gateway",
"Push_gateway": "Gateway",
Expand Down Expand Up @@ -3467,4 +3469,4 @@
"Your_question": "Your question",
"Your_server_link": "Your server link",
"Your_workspace_is_ready": "Your workspace is ready to use 🎉"
}
}
4 changes: 2 additions & 2 deletions server/lib/cordova.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ function configurePush() {
apn,
gcm,
production: settings.get('Push_production'),
sendInterval: 5000,
sendBatchSize: 10,
sendInterval: settings.get('Push_send_interval'),
sendBatchSize: settings.get('Push_send_batch_size'),
});

if (settings.get('Push_enable_gateway') === true) {
Expand Down