[NEW] Add ability to users reset their own E2E key#15777
Merged
sampaiodiego merged 3 commits intodevelopfrom Nov 20, 2019
Merged
[NEW] Add ability to users reset their own E2E key#15777sampaiodiego merged 3 commits intodevelopfrom
sampaiodiego merged 3 commits intodevelopfrom
Conversation
Contributor
|
I think this makes sense. Do you know what happens to existing conversations? Are they completely locked out of message history or does it rekey? If rekeys we need to follow this up some how and alert those conversations of key change. Maybe in either case it should |
Contributor
Author
|
When you login again it rekeys based on the online users of each encrypted room. |
sampaiodiego
approved these changes
Nov 20, 2019
Member
|
@geekgonecrazy the main idea behind this change is to remove this power from sys admins. we definitely need to improve the overall UX regarding E2E.. but before this changes, the end user could have their E2E reset and not even know what happened. |
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE_NUMBER