[FIX] Duplicate label 'Hide Avatars' in accounts #15694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The labels were of two different nature, for hiding avatars and to hide avatars in room view.
MartinSchoeler
requested changes
Oct 29, 2019
| "Hidden": "Hidden", | ||
| "Hide": "Hide", | ||
| "Hide_Avatars": "Hide Avatars", | ||
| "Hide_Avatars_Sidebar": "Hide Avatars Sidebar", |
Member
There was a problem hiding this comment.
Suggested change
| "Hide_Avatars_Sidebar": "Hide Avatars Sidebar", | |
| "Hide_Avatars_Sidebar": "Hide Avatars in Sidebar", |
| </div> | ||
| </div> | ||
|
|
||
| <div class="input-line double-col" id="hideAvatars"> |
Member
There was a problem hiding this comment.
This ID will conflict with the other hideAvatars preference ID
Contributor
Author
|
@MartinSchoeler I have made the changes as suggested by you, and it works fine. Below attatched are some screenshots for reference. |
ggazzo
approved these changes
Oct 29, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The labels were of two different nature, for hiding avatars and to hide avatars in room view.
Closes #15585
Hide AvatarsandHide Avatars Sidebar