[IMPROVEMENT] Button SaveChanges on Admin settings #15649
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceloschmidt
requested changes
Oct 23, 2019
| const query = { group, changed: true }; | ||
| const rcSettings = TempSettings.find(query, { fields: { _id: 1, value: 1, editor: 1 } }).fetch() || []; | ||
| if (rcSettings.length === 0) { | ||
| e.target.innerText = TAPi18n.__('Save_changes'); |
Member
There was a problem hiding this comment.
Shouldn't you also remove the disabled property here?
| const failedSettings = []; | ||
|
|
||
| settings.batchSet(rcSettings, (err) => { | ||
| e.target.innerText = TAPi18n.__('Save_changes'); |
Contributor
Author
There was a problem hiding this comment.
In the old version, when the settings is saved the button is change to disabled until you change some input.
If i add disabled false the button is forced to change, and "stop to saving" until you change some input
Contributor
|
@oguhpereira What about bring it to #15452? 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6463
In this pull-request change, when the user click on button SaveChanges the innerText is changed to Saving and the button is blocked with
disabled=truefor prevents the user from clicking twice.@marceloschmidt, @ggazzo