[FIX] Do not allow passwords on private channels #15642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
approved these changes
Oct 22, 2019
ggazzo
requested changes
Oct 28, 2019
| realValue: null, | ||
| canView() { | ||
| return roomTypes.roomTypes[room.t].allowRoomSettingChange(room, RoomSettingsEnum.JOIN_CODE) && hasAllPermission('edit-room', room._id); | ||
| return room.t !== 'p' && roomTypes.roomTypes[room.t].allowRoomSettingChange(room, RoomSettingsEnum.JOIN_CODE) && hasAllPermission('edit-room', room._id); |
Member
There was a problem hiding this comment.
please update allowRoomSettingChange for private channels
|
|
Member
|
@ggazzo can please you reprioritize this? |
gabriellsh
added a commit
that referenced
this pull request
May 13, 2020
… integrations * 'integrations' of github.com:RocketChat/Rocket.Chat: [NEW] Add Permissions to deal with Omnichannel visitor past chats history (#17580) [NEW] Add permissions to deal with Omnichannel custom fields (#17567) [FIX] Livechat iframe allow microphone and camera (#9956) [FIX] Do not allow passwords on private channels (#15642) [FIX] Mail Messages > Cannot mail own user. (#17625) [FIX] remove multiple options from dontAskMeAgain (#17514) [FIX] Notification sounds (#17616) [FIX] Resolve 'app already exists' error on app update (#17544) [NEW] Unread bars on sidebar (#16862) [FIX] Relative image path in oembededUrlWidget (#15902) Regression: Do not show custom status inside sequential messages (#17613)
ggazzo
added a commit
that referenced
this pull request
May 16, 2020
* 'develop' of github.com:RocketChat/Rocket.Chat: (25 commits) [FIX] Not redirecting to `First Channel After Login` on register (#17664) Regression: Pressing enter on search reloads the page - admin pages (#17663) [NEW] Admin refactor Second phase (#17551) [IMPROVE] Unused styles (#17554) [FIX] Directory search user placeholder (#17652) [NEW] Added "Add custom emoji" link to emoji picker (#16250) [FIX] Marketplace tiered pricing plan wording (#17644) [FIX] Secret Registration not properly validating Invite Token (#17618) Improve: New PR Template (#16968) Add engine versions for houston with templates (#17403) Use Users.findOneByAppId instead of querying directly (#16480) Remove unnecessary setting redefinition (#17587) Deprecate compatibility cordova setting (#17586) Hyper.sh went out of business in early 2019 (#17622) [NEW] Add Permissions to deal with Omnichannel visitor past chats history (#17580) [NEW] Add permissions to deal with Omnichannel custom fields (#17567) [FIX] Livechat iframe allow microphone and camera (#9956) [FIX] Do not allow passwords on private channels (#15642) [FIX] Mail Messages > Cannot mail own user. (#17625) [FIX] remove multiple options from dontAskMeAgain (#17514) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13750