Skip to content

[FIX] Changed cmsPage Style #15632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 6 commits into from
Nov 4, 2019
Merged

[FIX] Changed cmsPage Style #15632

ggazzo merged 6 commits into from
Nov 4, 2019

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Oct 22, 2019

Removed the gray margins as suggested on #14248

@gabriellsh
[FIX] Blocked Show_Setup_Wizard Option
1438582 
As described in issue RocketChat#13840, if the Show Setup Wizard option is changed to pending, no one can enter the server anymore.

Blocked the option in the admin UI so it only shows the status.
@gabriellsh
[FIX] Changed cmsPage Style
36032d9 
Removed the gray margins as suggested on RocketChat#14248
@gabriellsh
Revert "[FIX] Changed cmsPage Style"
bbaba86 
This reverts commit 36032d9.
@gabriellsh
Revert "Revert "[FIX] Changed cmsPage Style""
aaec419 
This reverts commit bbaba86.
@gabriellsh
Revert "[FIX] Blocked Show_Setup_Wizard Option"
64e1c22 
This reverts commit 1438582.
@MartinSchoeler
Copy link
Member

MartinSchoeler commented Oct 29, 2019

@gabriellsh could you fix the linting issues? Thanks!


app/theme/client/imports/general/base_old.css
 5035:1   ✖  Unexpected whitespace at end of line   no-eol-whitespace  
 5041:14  ✖  Unexpected unit                        length-zero-no-unit

@gabriellsh
Copy link
Member Author

gabriellsh commented Oct 30, 2019

@MartinSchoeler done!

MartinSchoeler
MartinSchoeler approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me!

@ggazzo ggazzo merged commit 29d3e8c into RocketChat:develop Nov 4, 2019
@sampaiodiego sampaiodiego mentioned this pull request Nov 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabriellsh @MartinSchoeler @ggazzo