[FIX] Issues saving audio notifications #15428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15399 - Saving audioNotificationValue from pushNotificationsFlexTab stores incorrect value
The incorrect value was being saved to the DB. The "value" from the UI dropdown has a concatenated string (it looks like "beep Beep") only the first portion of this string should be saved to the DB however the entire string was being saved, causing the notification to break. My fix splits the string and saves only the first portion.
Closes #15427 - Setting a channel's audio sound to default breaks audio notifications
Separate but related issue. Subscription "audioNotificationValue" field is set to "0" when it is switched back to "default" from another value (I don't know why this is set to 0 rather than removed or set to null, but it is). The audio playing code on the client UI doesn't recognise a value of "0" as being allowed, so it tries to play a sound named "audio#0" instead of using the path designed for the default sound, my fix recognises a "0" as the same as a "not set" value and uses the account default.