Skip to content

[NEW] Only Load CodeMirror code when it is needed #15351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 2 commits into from
Sep 13, 2019
Merged

[NEW] Only Load CodeMirror code when it is needed #15351

ggazzo merged 2 commits into from
Sep 13, 2019

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Sep 12, 2019 •
edited
Loading

This makes it so that all the code that runs codemirror loads to the browser only when the codemirror textarea is rendered

@ggazzo ggazzo added the area: ui Touches the code on client side label Sep 12, 2019
@ggazzo ggazzo added this to the 2.1.0 milestone Sep 12, 2019
@ggazzo ggazzo changed the title [New] Only Load Codemirror code when it is rendered [NEW] Only Load Codemirror code when it is rendered Sep 12, 2019
@ggazzo ggazzo changed the title [NEW] Only Load Codemirror code when it is rendered [NEW] Only Load CodeMirror code when it is needed Sep 12, 2019
@ggazzo ggazzo merged commit 212621f into develop Sep 13, 2019
@ggazzo ggazzo deleted the lazyload-codemirror branch September 13, 2019 14:13
@sampaiodiego sampaiodiego mentioned this pull request Sep 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

area: ui Touches the code on client side

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@MartinSchoeler @ggazzo