Skip to content

[FIX] login via GitLab #14929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FIX] login via GitLab #14929

wants to merge 1 commit into from

Conversation

dasjoe
Copy link
Contributor

@dasjoe dasjoe commented Jul 4, 2019

  • Update identityPath as API v3 was removed from Gitlab 11
  • Enable mergeUsers

Closes #14307

API v3 removal: https://gitlab.com/gitlab-org/gitlab-ce/issues/36819
Without enabling mergeUsers we experience issues where users can no longer login, User with username xyz already exists

* Update identityPath as API v3 was removed from Gitlab 11
* Enable mergeUsers
@CLAassistant
Copy link

CLAassistant commented Jul 4, 2019

CLA assistant check
All committers have signed the CLA.

@sampaiodiego sampaiodiego requested a review from rodrigok July 16, 2019 18:55
@sampaiodiego
Copy link
Member

thanks @dasjoe for your contribution.

we're evaluating the impact of this change, specially for those who cannot upgrade their gitlab.

@rodrigok
Copy link
Member

@dasjoe the solution we found was:

  1. Expose all string properties like identityPath as fields to be editable;
  2. Change the default value of identityPath to the new API version for new installations;
  3. Keep the v3 for those that are already using rocket.chat;

What do you think?

@Hudell will work on this.

@sampaiodiego
Copy link
Member

Thanks @dasjoe .. I've merged the other PR that also updates the identityPath to v4 and added you as co-author..

@dasjoe dasjoe deleted the patch-1 branch October 28, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab OAUTH Failure
5 participants