Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callbacks perf #14915

Merged
merged 23 commits into from
Jul 4, 2019
Merged

Callbacks perf #14915

merged 23 commits into from
Jul 4, 2019

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 2, 2019 •
edited
Loading

I used:

const combine = (f, x) => (e, ...constants) => x(f(e, ...constants), ...constants);

to create a single function to avoid .reduce each time we invoke a callback.

I set a name for each callback to help Prometheus to show the callbacks name properly

I removed the timers, and created a wrappers IF we want to use, if not we dont need track this time anymore.

@ggazzo ggazzo requested a review from sampaiodiego July 2, 2019 18:50
@ggazzo ggazzo requested review from cardoso and d-gubert and removed request for cardoso July 2, 2019 20:11
sampaiodiego
sampaiodiego requested changes Jul 2, 2019
View reviewed changes
app/callbacks/lib/callbacks.js Outdated Show resolved Hide resolved
sampaiodiego
sampaiodiego reviewed Jul 2, 2019
View reviewed changes
app/callbacks/lib/callbacks.js Outdated
};


const empty = (e) => e;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

sampaiodiego
sampaiodiego requested changes Jul 2, 2019
View reviewed changes
app/callbacks/lib/callbacks.js Outdated Show resolved Hide resolved
app/graphql/server/resolvers/messages/chatMessageAdded.js Outdated Show resolved Hide resolved
app/search/server/events/events.js Outdated Show resolved Hide resolved
tassoevan
tassoevan requested changes Jul 3, 2019
View reviewed changes
app/callbacks/lib/callbacks.js Outdated Show resolved Hide resolved
app/callbacks/lib/callbacks.js Outdated Show resolved Hide resolved
app/callbacks/lib/callbacks.js Outdated Show resolved Hide resolved
app/callbacks/lib/callbacks.js Outdated Show resolved Hide resolved
@ggazzo ggazzo merged commit 3661c63 into develop Jul 4, 2019
@ggazzo ggazzo deleted the callbacks-perf branch July 4, 2019 00:46
@sampaiodiego sampaiodiego mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego requested changes

@tassoevan tassoevan tassoevan approved these changes

@d-gubert d-gubert Awaiting requested review from d-gubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @tassoevan @sampaiodiego