[FIX] Channel Announcements not working #14635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tassoevan would you please review |
|
Ended up having to merge this into my own fork manually. It does seem to fix the issue. |
tassoevan
requested changes
Aug 27, 2019
app/ui/client/views/app/room.js
Outdated
| message.tokens.map((msg) => { | ||
| message.html = message.html.replace(msg.token, msg.text); | ||
| return message.html; | ||
| }); |
Contributor
There was a problem hiding this comment.
Take a look at the renderMessageBody helper. It encapsulates the callback calling and the replacement of tokens.
…into pr/14635-knrt10-issue14346
tassoevan
approved these changes
Oct 18, 2019
rodrigok
changed the title
rodrigok
pushed a commit
that referenced
this pull request
Oct 24, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14346
cc @tassoevan @ggazzo would you please review