[FIX] Encode custom oauth2 URL params #13373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
InstinctBas
force-pushed
the
escape_uri_custom_oauth
branch
from
d2c7fdb to
3c478d9
Compare
# Conflicts: # packages/rocketchat-custom-oauth/client/custom_oauth_client.js
rodrigok
approved these changes
Jun 19, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12654
Setting up a custom oauth2 client the parameters aren't being URI encoded. This is especially troublesome with state as the = or == at the end of the base64 encoded value cause certain oauth2 servers to not accept the values.
This PR simply URI encodes the value.