Skip to content

[NEW] Add rate limiter to REST endpoints - #11251

Merged
rodrigok merged 18 commits into
developfrom
fix-rest-login-rate-limit
Jan 19, 2019
Merged

[NEW] Add rate limiter to REST endpoints#11251
rodrigok merged 18 commits into
developfrom
fix-rest-login-rate-limit

Conversation

@MarcosSpessatto

Copy link
Copy Markdown
Contributor

This pull request enables the addition of rate limiters to the REST endpoints.

Unknown added 2 commits June 19, 2018 14:28
Unknown
Fix REST login rate limit
Unknown
Added the possibility to add Rate Limiter config to REST endpoints
@MarcosSpessatto MarcosSpessatto self-assigned this Jun 25, 2018
@engelgabriel
engelgabriel temporarily deployed to rocket-chat-pr-11251 June 25, 2018 17:08 Inactive
Comment thread packages/rocketchat-api/server/api.js Outdated
Comment thread packages/rocketchat-api/server/api.js Outdated
Comment thread packages/rocketchat-api/server/api.js Outdated
Unknown added 2 commits June 26, 2018 15:55
Unknown
Add default rule to REST rate limiter
@engelgabriel
engelgabriel temporarily deployed to rocket-chat-pr-11251 June 26, 2018 19:12 Inactive
Comment thread packages/rocketchat-api/server/api.js Outdated
Unknown
Add Settings to controle rate limiter in dev environment and a permission with bot role by default in rest rate limiter
@engelgabriel
engelgabriel temporarily deployed to rocket-chat-pr-11251 June 29, 2018 13:38 Inactive
vynmera
vynmera previously approved these changes Jun 29, 2018

@vynmera vynmera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Unknown
Add default timeout and number of calls to the rate limiter in Rest API
@engelgabriel

Copy link
Copy Markdown
Member

@sampaiodiego

Copy link
Copy Markdown
Member

@MarcosSpessatto can you please fix the conflicts? thx

@engelgabriel
engelgabriel temporarily deployed to rocket-chat-pr-11251 September 12, 2018 21:07 Inactive
Comment thread packages/rocketchat-authorization/server/startup.js Outdated
@engelgabriel
engelgabriel temporarily deployed to rocket-chat-pr-11251 November 14, 2018 13:48 Inactive
@engelgabriel
engelgabriel temporarily deployed to rocket-chat-pr-11251 November 14, 2018 13:49 Inactive
@MarcosSpessatto MarcosSpessatto added this to the 0.72.0 milestone Nov 14, 2018
@engelgabriel
engelgabriel temporarily deployed to rocket-chat-pr-11251 November 14, 2018 13:50 Inactive
@engelgabriel
engelgabriel temporarily deployed to rocket-chat-pr-11251 November 19, 2018 12:05 Inactive
@rodrigok
rodrigok temporarily deployed to rocket-chat-pr-11251 November 20, 2018 18:28 Inactive
@theorenck theorenck modified the milestones: 0.72.0, Short-term Dec 12, 2018
@MarcosSpessatto MarcosSpessatto modified the milestones: Short-term, 0.74.0 Jan 14, 2019
@engelgabriel
engelgabriel temporarily deployed to rocket-chat-pr-11251 January 14, 2019 19:43 Inactive
@rodrigok
rodrigok temporarily deployed to rocket-chat-pr-11251 January 19, 2019 19:01 Inactive
@rodrigok
rodrigok temporarily deployed to rocket-chat-pr-11251 January 19, 2019 19:17 Inactive
@rodrigok
rodrigok merged commit 929fa94 into develop Jan 19, 2019
@rodrigok
rodrigok deleted the fix-rest-login-rate-limit branch January 19, 2019 20:17
alansikora pushed a commit that referenced this pull request Jan 23, 2019
* Fix REST login rate limit

* Added the possibility to add Rate Limiter config to REST endpoints

* Add default rule to REST rate limiter

* Add Settings to controle rate limiter in dev environment and a permission with bot role by default in rest rate limiter

* Add default timeout and number of calls to the rate limiter in Rest API

* Fix wrong info in response header

* Add admin role to bypass rate limit by default

* Prevent check for permissions when no user logged in

* Remove duplicated entries at en.i18n.json
@sampaiodiego sampaiodiego mentioned this pull request Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants