Skip to content

[NEW] Forward messages #11179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[NEW] Forward messages #11179

wants to merge 11 commits into from

Conversation

cmrd-senya
Copy link

@cmrd-senya cmrd-senya commented Jun 18, 2018 •
edited by engelgabriel
Loading

Closes #396

This is a follow up for #9180 with fixes proposed by the reviewer.

The PR adds action Forward to the message menu which opens forwarding dialog. There you can select target channels to forward message to.

@cmrd-senya cmrd-senya force-pushed the forward-messages.new branch from 1550dec to d9cae75 Compare June 18, 2018 20:02
@ggazzo ggazzo added the ui/ux label Jun 20, 2018
@ggazzo ggazzo added this to the 0.67.0 milestone Jun 20, 2018
vynmera
vynmera suggested changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@vynmera vynmera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! I added some i18n requests for English wording :)

@cmrd-senya cmrd-senya force-pushed the forward-messages.new branch from cfcfa2c to cc92b34 Compare June 25, 2018 16:40
@cmrd-senya
Copy link
Author

@vynmera, updated

vynmera
vynmera previously approved these changes Jun 25, 2018
View reviewed changes
@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
@theorenck theorenck modified the milestones: 0.68.0, Short-term Jul 31, 2018
@cmrd-senya cmrd-senya force-pushed the forward-messages.new branch 2 times, most recently from 9185fea to 18c2e83 Compare August 6, 2018 17:29
@cmrd-senya
Copy link
Author

Updated with conflicts resolved

@ggazzo ggazzo added the design label Aug 16, 2018
@cmrd-senya cmrd-senya force-pushed the forward-messages.new branch from 18c2e83 to 6932a0c Compare October 16, 2018 19:17
@cmrd-senya
Copy link
Author

Rebased

@Sing-Li
Copy link
Member

Sing-Li commented Oct 17, 2018 •
edited
Loading

@thiagosanchz This PR appears to be pending a UI/Ux approval / review since August. Is it possible to fast-track this?

Core devs seem to have vetted the code. The contributor ( @cmrd-senya thx!) has been patiently updating through our UI code change(s) since June. Thanks.

@cmrd-senya cmrd-senya force-pushed the forward-messages.new branch from 6932a0c to 3c9615a Compare October 18, 2018 13:15
@thiagosanchz
Copy link

@Sing-Li @cmrd-senya and @ggazzo Is really useful and the flow is perfect! Let's merge ;)

@cmrd-senya cmrd-senya force-pushed the forward-messages.new branch 2 times, most recently from 3376f74 to b140fe5 Compare November 13, 2018 11:31
@tassoevan tassoevan removed their assignment May 12, 2020
@conradmunoz
Copy link

Hi guys,

Is there a workaround for this?

@scratttt
Copy link

scratttt commented Dec 4, 2020

Hi guys! Is it possible to add this feature?

Thank you!!

@Mr-Norrell
Copy link

Hey guys!
Seems a great feature here waits for a little supervision. Could you please make the time for passing the remaining tests and resolving the conflicts once? Or tell us when to expect to see the feature released maybe?

Thanks

@AvivBenShoham
Copy link

So many people are waiting for this feature, can somebody finish the last tests and approve it?

AvivBenShoham
AvivBenShoham reviewed Mar 24, 2021
View reviewed changes
app/ui/client/views/app/forwardMessage.js
if (rooms.length > 0) {
rooms.forEach(async (room) => {
await call('sendMessage', {
_id: Random.id(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you generate a _id for the 'sendMessage' function?
You don't need to

@jsalatiel
Copy link

@sampaiodiego Is this in the roadmap ? it is really similar to RocketChat/Rocket.Chat.ReactNative#2849 .

Forward is a great missing feature.

@sampaiodiego
Copy link
Member

@sampaiodiego Is this in the roadmap ? it is really similar to RocketChat/Rocket.Chat.ReactNative#2849 .

Forward is a great missing feature.

hi @jsalatiel this is actually a question to @milton-rucks

@jsalatiel
Copy link

@milton-rucks

@leofabri
Copy link

Any news about this? My users keep making the mistake of copying the link to a message and exchanging it... we all miss the forward feature

@f97-xyz
Copy link

f97-xyz commented Jun 17, 2021

Any new updates?

@bryanpedini
Copy link

Is this still waiting for LGTM approval?
From what I can see tests are fine and codebase is already rebased to the latest changes, can this be merged soon?

Thanks.

@languagedan
Copy link

Any update on this feature? My team is looking to switch to Rocket.Chat as our collaboration platform. The forward feature is a must-have for our use case. Thanks.

@MrPoint1400
Copy link

+1

@caiovictormc
Copy link

+1

Any update? My team is also implementing this flow through the API. This feature is essential.

@tassoevan tassoevan removed the design label Oct 26, 2022
@ggazzo ggazzo requested a review from dougfabris November 24, 2022 17:40
@ggazzo ggazzo modified the milestones: Short-term, 6.0.0-pre Nov 24, 2022
@dougfabris dougfabris changed the title Forward messages [NEW] Forward messages Nov 24, 2022
@MrPoint1400
Copy link

+1

@MrPoint1400 MrPoint1400 mentioned this pull request Jan 8, 2023
Closed
@MrPoint1400
Copy link

+1

@dougfabris dougfabris self-assigned this Feb 27, 2023
@dougfabris dougfabris mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvivBenShoham AvivBenShoham AvivBenShoham left review comments

@vynmera vynmera vynmera left review comments

@ggazzo ggazzo Awaiting requested review from ggazzo

@dougfabris dougfabris Awaiting requested review from dougfabris

Assignees

@dougfabris dougfabris

Labels
communityPR stat: conflict ui/ux
Projects
None yet
Milestone
Next-release-prep
Development

Successfully merging this pull request may close these issues.

Ability forward messages into other chat rooms