-
Notifications
You must be signed in to change notification settings - Fork 11.6k
Setup for application tests and package testing #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
oh got it working! You sir rock! Is the jasmine piece of the folder structure needed? If not maybe we could take it out? So we can make this as simple as possible. |
I don't think it is needed, but should we add another testing framework to our stack it would be good to have those test cases organized IMHO. |
…alone-package-testing Conflicts: .meteor/versions packages/rocketchat-markdown/package.js
…meteor-velocity/meteor-stubs/#11)
@RocketChat/owners Added Travis CI scripts and removing testing dependencies. This should be ready to merge and will help us setting up #1074 |
…h Underscore test stubs.
…Chat/Rocket.Chat into standalone-package-testing
I think you guys are missing the latest chrome, so Karma can't start. Try this adding this to your travis yml:
|
Add missing chrome addons
@samhatoum Thank you! The tests-after-build proceeded much more smoothly. One question - the set-up time per packaged test is extremely long right now (for unit test where we might have thousands to run per build ... and if we have 10s of packages) - total build time can become quite a problem ... any ideas on how best to deal with it/structure our tests? @gmsecrieru - please examine the logs - as there are multiple errors (one being web socket ECONNERR) in the logs but the final return code is 0 = green. |
@Sing-Li no problem regarding packages, there's a couple of things you can do.
|
you should consider using the |
@samhatoum Thanks again for the great suggestions! |
thanks @samhatoum. so many things we can learn from him! |
@leefaus no worries, happy to help |
Attempting to include package tests in-line to determine travis-ci load and time elapsed. closes #1044
@samhatoum - to avoid doing an extra build (takes up to 8 minutes - and we needed to do it twice already) just for testing, we included the following packages into our demo-server production build:
Are they placebo when not activated? Will there be any side-effects? TIA |
you should add
then they will be placebo, otherwise Jasmine will start mirrors |
* master: (28 commits) preventDefault on shift + esc shortcut Close #1222; Fix shared variable with username info when generate avatar Merging .travis.yml meteor update Updating meteor Applying velocity-cli for application test in CI mode Add add ons per #1045 New attempt for application test. Test attempt. Added application tests Final updated versions Updating versions Explicitly declaring sanjo:jasmine version. Simplifying rocketchat:markdown tests since its falling because of underscore.string Fixing call to underscore.string 'trim' method to avoid conflicts with Underscore test stubs. Fixed path for velocity-cli execution Added correct velocity-cli package Setting up Travis CI for test execution and removing test dependencies Updating to support ServiceConfiguration.configurations stub method (meteor-velocity/meteor-stubs/#11) Settings file should only be available on server. ...
@samhatoum We just merged a Cordova build to main branch, and it has a local copy of autoupdate 1.2.4. The build breaks now when running velocity due to ISOBUILD constraints violation. Have you seen this before? TIA
|
Does it work locally? Try zapping the versions file maybe? |
@samhatoum - same behavior locally. zapping the versions file made no difference. it added back autoupdate 1.2.4 -- seems like something in velocity start is insisting on 1.2.3 of autoupdate. |
Chore: livechat v1.9.4.b1ed874 - remove composer on close chat; disable room…
Should close #1044