[FIX] Missing RocketApps input types #10394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graywolf336
reviewed
Apr 9, 2018
| @@ -5,6 +5,16 @@ import { AppEvents } from '../communication'; | |||
|
|
|||
|
|
|||
| Template.appManage.onCreated(function() { | |||
|
|
|||
| if (RocketChat.settings.cachedCollectionPrivate == null) { | |||
There was a problem hiding this comment.
What's this for in this file? As I don't see it being used anywhere except the commented out code below on line 98..
karlprieb
approved these changes
Apr 10, 2018
| @@ -5,6 +5,7 @@ import { AppEvents } from '../communication'; | |||
|
|
|||
|
|
|||
| Template.appManage.onCreated(function() { | |||
|
|
|||
| @@ -74,6 +75,51 @@ Template.apps.onDestroyed(function() { | |||
| }); | |||
|
|
|||
| Template.appManage.helpers({ | |||
| // setEditorOnBlur(_id) { | |||
There was a problem hiding this comment.
can you remove this comment?
karlprieb
suggested changes
Apr 10, 2018
karlprieb
approved these changes
Apr 11, 2018
rodrigok
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some fields we the we have not implemented yet (all fields on image are working)