[FIX] Update AmazonS3 file upload with error handling and sync operation #10372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhavmalhotra3089
changed the title
madhavmalhotra3089
force-pushed
the
fix-issue-10289
branch
from
ab0d92b to
e51d022
Compare
madhavmalhotra3089
force-pushed
the
fix-issue-10289
branch
from
e51d022 to
7b34a3b
Compare
madhavmalhotra3089
force-pushed
the
fix-issue-10289
branch
from
7b34a3b to
57a8483
Compare
|
|
# Conflicts: # packages/rocketchat-file-upload/server/config/AmazonS3.js
rodrigok
approved these changes
Jun 19, 2020
rodrigok
approved these changes
Jun 19, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #10289