[FIX] Channel/Room inconsistency for leave and hide options #10165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dalben96
approved these changes
Mar 19, 2018
Dalben96
approved these changes
Mar 19, 2018
Contributor
|
Does it say leave a private group or leave a channel? |
Contributor
Author
|
For a group, it says 'group'. For a channel, it earlier said 'room' which has been changed to 'channel' @graywolf336 |
c0dzilla
force-pushed
the
channel-i18n-consistency
branch
from
4bc6fd1 to
a32dabc
Compare
c0dzilla
changed the title
rodrigok
approved these changes
Jun 19, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #10133
Replaces 'room' with 'channel' in hide and leave warnings for channel.