-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve sound of new direct message #71
Comments
I personally find both of those highly aggravating. The default notification sound should probably be more subtle (and only really apply for 'watched' channels, direct messages and highlights/mentions anyway). Aside from that, the SoundJay sounds are very clearly not OSI-compliant. From their Terms of Use:
This violates points 1, 3, 6 and 10. Rocket.Chat needs a properly licensed (set of) sound effects. Freesound.org has plenty of these. Acceptable licenses would be CC0 and CC-BY (plus 'public domain'). Unacceptable licenses are CC-NC (violating point 6), and CC-ND (violating point 3), although I believe the latter isn't used on Freesound. |
Depends on #222 |
Allow passing of messageId in upload file
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: