Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sound of new direct message #71

Closed
engelgabriel opened this issue May 31, 2015 · 3 comments · Fixed by #5366
Closed

Improve sound of new direct message #71

engelgabriel opened this issue May 31, 2015 · 3 comments · Fixed by #5366

Comments

@engelgabriel
Copy link
Member

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@diomed
Copy link
Contributor

diomed commented Jun 3, 2015

@joepie91
Copy link

joepie91 commented Jun 9, 2015

I personally find both of those highly aggravating. The default notification sound should probably be more subtle (and only really apply for 'watched' channels, direct messages and highlights/mentions anyway).

Aside from that, the SoundJay sounds are very clearly not OSI-compliant. From their Terms of Use:

You are allowed to use the sounds free of charge and royalty free in your projects (such as films, videos, games, presentations, animations, stage plays, radio plays, audio books, apps) be it for commercial or non-commercial purposes.

But you are NOT allowed to

  • post the sounds (as sound effects or ringtones) on any website for others to download, copy or use
  • use them as a raw material to create sound effects or ringtones that you will sell, distribute or offer for downloading
  • sell or license the sounds (as sound effects or ringtones) to anyone else
  • claim the sounds as yours
  • link directly to individual sound files on our server
  • distribute the sounds in apps or computer programs that are clearly sound related in nature (such as sound machine, funny sounds app, sound therapy app, ringtone maker, etc.). If you are developing such programs, contact us for licensing options.
  • distribute the sounds in apps or computer programs that use the sounds as the program's sound resource library for other people's use (such as animation creator, video editing app, song maker software, ebook creator, etc.). If you are developing such programs, contact us for licensing options.
  • use the sounds to create so-called 'video sound effects'. An example would be a video titled 'dog sound effect' that simply plays a dog sound effect.

This violates points 1, 3, 6 and 10. Rocket.Chat needs a properly licensed (set of) sound effects. Freesound.org has plenty of these.

Acceptable licenses would be CC0 and CC-BY (plus 'public domain'). Unacceptable licenses are CC-NC (violating point 6), and CC-ND (violating point 3), although I believe the latter isn't used on Freesound.

@engelgabriel engelgabriel added this to the v1.1 milestone Jul 1, 2015
@engelgabriel
Copy link
Member Author

Depends on #222

@engelgabriel engelgabriel modified the milestones: 0.52.0, Short-term Feb 6, 2017
bhardwajaditya pushed a commit to bhardwajaditya/Rocket.Chat that referenced this issue Sep 30, 2019
Allow passing of messageId in upload file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants